BetaFix: Fix IPP #14681
Merged
BetaFix: Fix IPP #14681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
malinajirka
added
the
feature: mobile payments
Collaborator
Project dependencies changeslist! Upgraded Dependencies
com.squareup.okhttp3:okhttp-tls:5.1.0, (changed from 4.12.0)tree-\--- project :libs:cardreader
- \--- com.stripe:stripeterminal-taptopay:4.6.0
- +--- com.squareup.okhttp3:okhttp-tls:4.12.0
- | +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.1.0 (*)
- | +--- com.squareup.okio:okio:3.6.0 -> 3.15.0 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
- \--- com.stripe:stripeterminal-internal-common:4.6.0
- \--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
++--- project :libs:fluxc
+ \--- com.squareup.okhttp3:okhttp-tls:5.1.0
+ +--- com.squareup.okhttp3:okhttp:5.1.0 (*)
+ +--- com.squareup.okio:okio:3.15.0 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib:2.2.0 (*)
+\--- project :libs:cardreader
+ \--- com.stripe:stripeterminal-taptopay:4.6.0
+ +--- com.squareup.okhttp3:okhttp-tls:4.12.0 -> 5.1.0 (*)
+ \--- com.stripe:stripeterminal-internal-common:4.6.0
+ \--- com.squareup.okhttp3:okhttp-tls:4.12.0 -> 5.1.0 (*) |
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
kidinov
approved these changes
Oct 2, 2025
Contributor
kidinov
left a comment
kidinov
left a comment
There was a problem hiding this comment.
LGTM! Both TTP and IPP test well.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/23.3 #14681 +/- ##
==================================================
- Coverage 38.50% 38.50% -0.01%
+ Complexity 9775 9774 -1
==================================================
Files 2066 2066
Lines 115514 115514
Branches 15390 15390
==================================================
- Hits 44477 44476 -1
Misses 66906 66906
- Partials 4131 4132 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR explicitly declares okhttp tls dependency to avoid
java.lang.NoClassDefFoundError: Failed resolution of: Lokhttp3/internal/Util;error during card reader connection flow.This issue surfaced when we updated okhttp 4.9.0 -> 5.1.0 in #14587.
Steps to reproduce
Testing information
The tests that have been performed
The above + TTP testing on production build
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.